Fix macOS release game module install names#80
Merged
Conversation
Copilot created this pull request from a session on behalf of
themuffinator
June 23, 2026 07:31
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manual release workflow was failing for unsigned macOS ARM64 artifacts because the packaged game module dylibs had no
LC_ID_DYLIBinstall name. Release validation expects package-relative install names such as@loader_path/game-sp_arm64.dylib, so both macOS packaging lanes stopped in the package step.Root cause
shared_module(...), which did not yield the install-name metadata the packaging validation checks withotool -D.Build target adjustment
game-spandgame-mptargets incontent/baseoq4/meson.buildfromshared_module(...)toshared_library(...).Regression coverage
tools/tests/macos_metal_bridge.pyto assert that the Darwin game-module targets remainshared_library(...).